Open
Conversation
al20ov
force-pushed
the
coredns-1.14.2
branch
2 times, most recently
from
319f54c to
4766a8f
Compare
Member
|
Sounds like the test is working. |
Contributor
Author
|
@Duncaen you mean after the "fix"? Because without it, i686 doesn't pass: https://github.com/void-linux/void-packages/actions/runs/23167280243/job/67310474534 |
Member
|
The point of tests is to identify issues, if we just disable all test that don't pass (for reasons besides the test being wrong) then we don't need to run tests. |
Contributor
Author
|
I know it's clearly not ideal and not a real fix. What do you suggest? That I add a disclaimer in the template that the tracing plugin will be broken on i686? Or we disable building for i686 entirely? Or that I just drop the PR until/if this gets fixed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
New release and I added
go_build_tags=grpcnotracebecause that's what coredns's Makefile builds with now: coredns/coredns@86d9bc7Also had to ignore tests for coredns/plugin/trace on i686 since datadog-go triggers a panic: unaligned 64-bit atomic operation on 32 bit systems